Allow Jenkins to parse the release Jenkinsfile before cancelling non-release triggers #9571
Conversation
…release triggers This way, we can update parameters/options and have Jenkins take them into account for the next build upon branch indexing or push, even though we don't release on branch indexing or push.
yrodiere
force-pushed
the
scheduled-release
branch
from
b921ae7 to
93b4d1a
Compare
|
Waiting to see the result on 6.6 before we merge here. See https://ci.hibernate.org/view/Release/job/hibernate-orm-release/job/6.6/ , build 99. Unfortunately it's being throttled right now, so we'll need to wait until tomorrow before we can see the effect... @beikov this makes me think the throttle probably doesn't make sense, since it takes into account non-release runs as well... ? And if we don't release on push, it's not really necessary. |
|
With your changes, the throttle should not be a problem anymore because it wouldn't even show up as build, or will we have to do something like the following for that? https://stackoverflow.com/questions/42798006/how-to-disable-automatic-build-from-scm-change-in-jenkinsfile/72917011#72917011 |
No, with my changes the build would still show up, with
If you want to disable builds on push, we can simply disable that in the web UI. Back to the problem... the throttle is pointless if we don't build on push, isn't it? Especially if we avoid allocating a node when we cancel the build ( |
I guess it is, yes. |
Ha, actually you removed it a while ago: 0c76b02#diff-39361c81949b88c7ae073b50cfbcae6b6d6479d0016dd6ae7d922ccd64952274L69 It's just that Jenkins never had a chance to parse the Jenkinsfile since your commit... Which hopefully my patch will fix. Bottom line: let's wait for the throttle to expire tomorrow and see what happens on 6.6. |
|
... and it did not work, the build ends up running anyway (and failing, for some reason): https://ci.hibernate.org/blue/organizations/jenkins/hibernate-orm-release/detail/6.6/99/pipeline I'll close this and revert the 6.6 change. |
…ing non-release triggers" This reverts commit ffecd7d. This reverts PR hibernate#9617 See hibernate#9571 (comment)
…ing non-release triggers" This reverts commit ffecd7d. This reverts PR #9617 See #9571 (comment)
This way, we can update parameters/options and have Jenkins take them into account for the next build upon branch indexing or push, even though we don't release on branch indexing or push.
NOTE: This is untested. Depending on how Jenkinsfiles get executed, this may or may not work.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.